Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cmake cleanup #28

Merged
merged 18 commits into from
Aug 18, 2017
Merged

More cmake cleanup #28

merged 18 commits into from
Aug 18, 2017

Conversation

piponazo
Copy link
Collaborator

In this Pull Request I am taking another step forward to have a cleaner CMake code. This is a list of the things done:

  • Remove unused CMake code: CMP0042 policy is not needed anymore. Since we require CMake 3.1 we can use directly MACOSX_PATH.
  • Simplify CMake code related with Compiler info.
  • Proper usage of the Threads module.
  • Remove useless calls to include_directories.
  • Fix inclusion of non-existing header file.
  • Move inclusion of a private header from a public one, to the .cpp file. (Issue detected thanks to the removal of include_directories calls)

piponazo and others added 18 commits August 18, 2017 13:55
@piponazo
Move sample applications from src/CMakeLists.txt to samples/CMakeList…
73f53cc 
…s.txt
@piponazo
Simplify CMake code, and unify to lower case commands
0ebd53b
@piponazo
Move inclusion of private header from .hpp to .cpp (not needed in the…
1c03767 
… .hpp)
@piponazo
Remove inclusion of many useless include_directories
ee61c24
@piponazo
Put all the CMake related with the exiv app together
57cd78b
@piponazo
Remove CMake policy CMP0042. CMake 3.1 already support MACOSX_RPATH
d29b3b6
@piponazo
Simplify compiler info handling in CMake
69fb40f
@piponazo
Remove unused cmake code
8dada35
@piponazo
Simplify CMake code for handling SSH and CURL cases
c507026
@piponazo
Do not include SSH and CURL include dirs globally. Do it properly for…
45807ca 
… the exiv2lib target
@piponazo
Use target_sources to extend the list of sources in exceptional situa…
f5f5826 
…tions
@piponazo
Simplify CMake code to identify FreeBSD systems
9808c3b
@piponazo
Fix linking problems with pthreads
93e603e
@piponazo
Remove more useless include_directories
27cde13
@piponazo
Fix inclusion of file
6be5278
@piponazo
Add list of things to do in the future
ca9ef34
Fixes for MSVC case
35c3e31
Remove old WORK_IN_PROGRESS file
461a34d
@clanmills clanmills merged commit ffb36ae into Exiv2:master Aug 18, 2017
@piponazo piponazo deleted the moreCMakeCleanup branch August 18, 2017 14:03
This was referenced Sep 24, 2017
Closed
Closed
Closed
@D4N D4N mentioned this pull request May 29, 2020
Closed
@DL4MW DL4MW mentioned this pull request Nov 30, 2021
Closed
@nicolasfella nicolasfella mentioned this pull request Jun 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piponazo @clanmills