Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New way to generate the XMP library (Using the CMake OBJECT LIBRARY concept) #27

Merged
merged 3 commits into from
Aug 16, 2017
Merged

New way to generate the XMP library (Using the CMake OBJECT LIBRARY concept) #27

merged 3 commits into from
Aug 16, 2017

Conversation

piponazo
Copy link
Collaborator

In this Pull Request I decided to improve the way in which we are handling the XMP support. These are the things I modified:

  • I moved the XMPSRC variable from the main CMakeLists.txt file to xmpsdk/CMakeLists.txt. Now the variable is only available in the scope of the xmpsdk folder.
  • Usage of the CMake OBJECT library concept to reuse object files. When EXIV2_ENABLE_XMP=ON and EXIV2_ENABLE_LIBXMP=ON, those object files are used to generate the xmp static library. When EXIV2_ENABLE_XMP=ON and EXIV2_ENABLE_LIBXMP=OFF, those object files are appended to the list of sources for the exiv2lib library.
  • Remove the dependency on ${EXPAT_LIBRARIES} from many targets. That dependency is already inherited from the exiv2lib target.
  • Continue with the unification of lower_case CMake commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants