New way to generate the XMP library (Using the CMake OBJECT LIBRARY concept) #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Pull Request I decided to improve the way in which we are handling the XMP support. These are the things I modified:
CMakeLists.txt
file toxmpsdk/CMakeLists.txt
. Now the variable is only available in the scope of the xmpsdk folder.EXIV2_ENABLE_XMP=ON
andEXIV2_ENABLE_LIBXMP=ON
, those object files are used to generate the xmp static library. WhenEXIV2_ENABLE_XMP=ON
andEXIV2_ENABLE_LIBXMP=OFF
, those object files are appended to the list of sources for the exiv2lib library.${EXPAT_LIBRARIES}
from many targets. That dependency is already inherited from the exiv2lib target.