Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated wind-utils submodule to latest commit. #1202

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

ddement
Copy link
Contributor

@ddement ddement commented Aug 1, 2023

This allows builds with wind-utils enabled to compile.

This allows builds with wind-utils enabled to compile.
Copy link
Contributor

@alanw0 alanw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all that was needed? I had been under the impression that there were some stk-mesh usage changes needed also...

@ddement
Copy link
Contributor Author

ddement commented Aug 2, 2023

@alanw0

The stk-mesh changes are only needed for running with the latest Trilinos. The culprit implicated by the filed issues was the move to MeshBuilder rather than the BulkData/MetaData constructors. There were also several other changes needed to build with the latest Trilinos, mostly related to our recent code deprecation cycles. We made those changes in a branch "update_latest_trilinos" on wind-utils. The plan is to merge that branch (and a similar branch here on Nalu-Wind) when everyone is comfortable with the loss of backward compatibility to old Trilinos versions.

The present update is all that is needed to build and run with the supported 13.4.0 Trilinos snapshot from 2/28/2023.

@ddement ddement merged commit 5c5f3d0 into master Aug 2, 2023
3 checks passed
@ddement ddement deleted the wind-utils_update branch August 2, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants