Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DNSScavengingForPrimaryDNSServer.ps1 #33

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Update DNSScavengingForPrimaryDNSServer.ps1 #33

merged 2 commits into from
Sep 9, 2019

Conversation

JasonCook599
Copy link
Contributor

Change DNS last scavenge time to be less than seven days from now, instead of more than seven days ago. Test current fails if scavenging occurred too recently.

Change DNS last scavenge time to be less than seven days from now, instead of more than seven days ago.
@PrzemyslawKlys
Copy link
Member

(Get-Date).AddDays(7) = 16th of September. This is the future. Everything will be less than that?

@PrzemyslawKlys
Copy link
Member

I think, fix for this would be changing LT to GT and leaving it as is. What do you think?

@JasonCook599
Copy link
Contributor Author

Both will work identically and I don't have a strong opinion either way. Personally, I find it easier to read/understand "add seven" than "add negative seven".

@PrzemyslawKlys
Copy link
Member

Are you sure?

(Get-Date).AddDays(7) = Future date
Any scavenging time - 5 days old, 500 days old will be Less Than that date.

(Get-Date).AddDays(-7) = Past Data (-7 days)
We expect scavenging Date to be greater than that. So 1-7 days will work, but not 8.

@JasonCook599
Copy link
Contributor Author

JasonCook599 commented Sep 9, 2019 via email

@PrzemyslawKlys
Copy link
Member

Thank you, please fix it so I can apply your fix!

@PrzemyslawKlys PrzemyslawKlys merged commit c5bb07a into EvotecIT:master Sep 9, 2019
@PrzemyslawKlys
Copy link
Member

Thank you! Really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants