In some situations, it is necessary to use credentials for getting the Domain Controller using the DetectDC parameter. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Credential to Get-ServerList if parameter credential is set
Added Credential to Get-ServerListLimited
Added Credential to Get-ServersList function
Removed Credential from Get-ServersListLimited
Refactor - Code Design
| @@ -30,7 +31,11 @@ function Get-ServersList { | |||
| } | |||
| if ($Target.DomainControllers.Enabled) { | |||
| if (-not $Quiet) { $Logger.AddInfoRecord("Preparing servers list - domain controllers autodetection") } | |||
| [Array] $Servers = (Get-WinADDomainControllers -SkipEmpty).HostName | |||
| if($Credential) { | |||
There was a problem hiding this comment.
Isn't it always true? Since you set it to Empty by default?
There was a problem hiding this comment.
I think you are right.
I will fix this
PrzemyslawKlys
changed the title
PrzemyslawKlys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find-Events via remoting doesn't work always.
In some situations, it is necessary to use credentials for getting the Domain Controller using the DetectDC parameter.
Added Credentials to all necessary functions