New testlab8 #48
Open
New testlab8 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evgueni-Petrov-aka-espetrov
requested changes
Jun 6, 2024
testlab8-base.c
Outdated
Comment on lines
194
to
148
| case VERTEX_COUNT: | ||
| return MakeInteger(test->VertexCount); | ||
| case EDGE_COUNT: | ||
| return MakeInteger(test->EdgeCount); | ||
| case EDGE: | ||
| assert(edgeIdx < test->EdgeCount); | ||
| return MakeEdge(test->Edges[edgeIdx].Begin, test->Edges[edgeIdx].End, test->Edges[edgeIdx].Length); | ||
| case ERROR_MESSAGE: | ||
| return MakeString(test->Message); | ||
| case MST_LENGTH: | ||
| return MakeInteger(test->MstLength); | ||
| default: | ||
| abort(); |
There was a problem hiding this comment.
форматирование нужно сохранить -- везде, где менялось только форматирование
testlab8-base.c
Outdated
Comment on lines
134
to
137
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
лишние пустые строки нужно убрать -- везде, где добавили
testlab8-base.c
Outdated
Comment on lines
31
to
66
| { {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {Feed, Check}, | ||
| {SpecialFeed, Check}, | ||
| }; |
There was a problem hiding this comment.
тут лучше
if (testIdx < ...) {
return {Feed, Check};
} else {
return {SpecialFeed, Check};
}
testlab8-base.c
Outdated
|
|
||
| enum { | ||
|
|
||
| VERTEX_FOR_LARGES = 5000, |
There was a problem hiding this comment.
VERTEX_FOR_LARGES нужно убрать
testlab8-base.c
Outdated
| @@ -109,13 +153,13 @@ static TTestcaseData GetFromTestcase(unsigned testcaseIdx, enum ETestcaseDataId | |||
| {2, 1, {{IGNORED_VERTEX_IDX}}, "bad number of lines"}, | |||
|
|
|||
| {0, 0, {{IGNORED_VERTEX_IDX}}, "no spanning tree"}, | |||
| {MAX_VERTEX_COUNT+1, 1, {{1, 1, 1}}, "bad number of vertices"}, | |||
| {MAX_VERTEX_COUNT + 1, 1, {{1, 1, 1}}, "bad number of vertices"}, | |||
There was a problem hiding this comment.
тут проблема, т.к. у Прима max vertex count -- 7К, а у Краскала -- 20К
нужно этот тест сделать по аналогии со Special
testlab8-base.c
Outdated
| @@ -300,7 +354,7 @@ static unsigned FindEdge(unsigned a, unsigned b) { | |||
| return IGNORED_EDGE_IDX; | |||
| } | |||
|
|
|||
| static int FindRoot(unsigned vertex, const unsigned parent[]) { | |||
| int FindRoot(unsigned vertex, const unsigned parent[]) { | |||
There was a problem hiding this comment.
нужно вернуть static, т.к. используется только в этом файле -- везде поправьте, где не по делу снесли
| const unsigned vertexCount = GetVertexCount(); | ||
| unsigned vertexParent[MAX_VERTEX_COUNT]; | ||
| unsigned* vertexParent = (unsigned*)malloc(vertexCount * sizeof(int)); | ||
| unsigned long long length = 0; |
There was a problem hiding this comment.
if (vertexParent == NULL) {
printf("malloc returned NULL -- please free ram and re-run tests\n");
return 1; // test failed
}| const unsigned vertexCount = GetVertexCount(); | ||
| unsigned vertexParent[MAX_VERTEX_COUNT]; | ||
| unsigned* vertexParent = (unsigned*)malloc(vertexCount * sizeof(int)); |
testlab8-0.c
Outdated
| start = RoundUptoThousand(GetTickCount() - start); | ||
|
|
||
| LabTimeout = (int)start + 3000; | ||
| LabMemoryLimit = 24 * (vertexCount + 1) * (vertexCount + 1) + 24 * vertexCount + MIN_PROCESS_RSS_BYTES; |
synt3se
force-pushed
the
master
branch
12 times, most recently
from
c792970
to
e8669c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.