add toggle option to core mode trigger #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kalobi pointed out that this could in theory break existing core mode triggers; as such do not merge until this is tested |
|
now tested with existing triggers! |
SnipUndercover
added a commit
to SnipUndercover/Everest
that referenced
this pull request
Apr 27, 2024
EverestModuleAssemblyContext.LoadUnmanagedFromThisMod() accesses the module meta's Hash. If a P/Invoke occurs in EverestModule.Load, the Hash has not yet been computed. This commit fixes that by calculating the hash if it is null. Fixes EverestAPI#671.
SnipUndercover
added a commit
to SnipUndercover/Everest
that referenced
this pull request
Apr 27, 2024
EverestModuleAssemblyContext.LoadUnmanagedFromThisMod() accesses the module meta's Hash. If a P/Invoke occurs in EverestModule.Load(), the Hash has not yet been computed. This commit fixes that by calculating the Hash if it is null. Fixes EverestAPI#671.
SnipUndercover
added a commit
to SnipUndercover/Everest
that referenced
this pull request
Apr 27, 2024
EverestModuleAssemblyContext.LoadUnmanagedFromThisMod(string) accesses the module meta's Hash. If a P/Invoke occurs in EverestModule.Load(), the Hash has not yet been computed, which crashes the game. This commit fixes that by calculating the Hash if it is null. Fixes EverestAPI#671.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds an
CoreModeTrigger.Modesenum, which is the same asSession.CoreModesbut with an extraToggleoption at the end.this is used for the
modeattribute, and when it is set toToggle, the trigger toggles the core mode.this means that when it is cold, it becomes hot, and vice versa; nothing happens if the core mode is
None.