Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to shutdown to mod updater screen #621

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

Wartori54
Copy link
Contributor

Fixes #249 by adding two buttons to the screen, one to shutdown and one to restart.

2023-04-28_23-53

Some translatable text needed to be added or modified, I am unsure on how to deal with missing translations so currently only the English.txt file was modified. Please notify me if this need to be changed.

Also the Update method was rewritten and spliced up to prevent too many layers of indentation.

@DemoJameson DemoJameson requested a review from maddie480 May 11, 2023 08:17
@caeyo
Copy link
Contributor

caeyo commented May 18, 2023

Very minor nitpick but just on the language, I'd go with the two actions being:

  • Restart
  • Exit

Exit just matches the phrasing the game uses in the main menu, mentioning Celeste is probably pretty redundant, and the ordering is super duper nitpicky but I guess it feels off to me because restart has been the default for a while and exit is also more "final". Simplifying down to Exit also means that the vanilla dialog translations can be used for that entry, if that helps

@Wartori54
Copy link
Contributor Author

Ok thats a good idea to minimize the translations needed.

@DemoJameson
Copy link
Member

DemoJameson commented Jul 31, 2023

found two issue:

  1. if only mod can be updated, after updating done, the restart button doesn't has focus
    image

  2. if more than one mod can be updated, after updating them one by one, the update all button doesn't replace to a text All mods have been updated.
    image

@Wartori54
Copy link
Contributor Author

Thank you @DemoJameson for your testing, those should be all fixed on latest commit. Really looking forward to getting this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to quit (not restart) Celeste after updating mods [enhancement]
3 participants