Deprecate __Ext classe members #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also states that they are effectively obsolete and no longer required by current code mod projects.
Adds obsolete attributes and updates references to the following Ext classes: - AreaData - AreaStats - CheckpointData - Decal - Dialog - GameplayRenderer - Level - LevelEnter - MainMenuSmallButton - MapData - ModeProperties
Add obsolete attributes and update references to the following Ext classes: - ObjModel - OuiChapterSelectIcon - OuiMainMenu - Player - PlayerHair - SaveData
Add obsolete attributes and update references to the following Ext classes: - Atlas - Coroutine - EntityList - MTexture - RendererList - Sprite - SpriteBank - VirtualAsset
Add obsolete attributes and update references to the following Ext classes: - VirtualContent - VirtualTexture
Implicit operators cannot be used because they are compiled to method calls.
An additional MapData field was accidentally getting added to the Session class, which the serializer was unable to process.
maddie480
reviewed
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Obsoleteattributes to redundant members and fixes references to them in Everest.This adds more casts to
patch_classes that become redundant, and it would be nice to be able to remove them at patch time, however it could be tricky to determine which ones are actually unnecessary.