Improvements for cassette music maps #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts two things in
CassetteBlockManager
:BeatIndexOffset
can now be set in map metadata instead of being forced to 5 for levels where the cassette track is the main music event (it's set to 5 inAwake
)beatIndex
adjustment is no longer hardcoded to 8 but will adjust to always use the second-to-last cassette colour if the beat is within the second half of a swap and the last colour if it's within the first half.BeatIndexOffset
should probably default to 0 for all non-vanilla levels. I believe this is what it should be, since it starting at 5 for levels with the cassette track as the main track is somewhat arbitrary (I believe only Farewell uses that in Vanilla). I wonder whether changing this default will break something; Is the offset of 5 beats compensated for within the FMOD project? Cassette swap cycles are usually eight beats, so that doesn't align with 5 at all.