Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discord rich presence on macOS #401

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

endorpersand
Copy link
Contributor

This commit doesn't rewrite Everest's DiscordRPC integration with Discord's GameSDK (like #307 requests), but it fixes rich presence not showing up on macOS and shouldn't interfere with rich presence on other platforms (though I haven't tested that).

@0x0ade
Copy link
Member

0x0ade commented Nov 21, 2021

Thanks for submitting the PR and reminding me that the "standard" way to check for macOS is broken with MonoKickstart 😅

Can you please give PlatformHelper.Is (available in the MonoMod.Utils namespace from the .dll of the same name) a try? It should be able to handle the macOS platform check just fine.

@endorpersand
Copy link
Contributor Author

Done. I can also confirm that this commit works on macOS.

@0x0ade
Copy link
Member

0x0ade commented Nov 22, 2021

Thank you :)

@0x0ade 0x0ade merged commit bf71639 into EverestAPI:dev Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants