Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lib-stripped artifact to build pipeline #372

Merged
merged 36 commits into from
Sep 28, 2021

Conversation

coloursofnoise
Copy link
Member

Generates an artifact using mono-cil-strip of the Celeste libs post-patch
For use by mods as part of their build pipelines

@WEGFan
Copy link
Member

WEGFan commented Aug 28, 2021

Maybe also split the process of patching to an individual one so we can add a patch check for commits across all versions of Celeste? (although only FNA is available since it's on Ubuntu)

@coloursofnoise
Copy link
Member Author

Maybe also split the process of patching to an individual one so we can add a patch check for commits across all versions of Celeste? (although only FNA is available since it's on Ubuntu)

Definitely in favour of this, including moving the patching to happen before creating artifacts, since if it fails patching then we probably shouldn't ship the build 😅
For this PR though I'd rather just get the lib-stripped artifact out and usable, and I'll work on a second PR for proper patch checks at a later date.

@0x0ade 0x0ade merged commit 88ffe01 into EverestAPI:dev Sep 28, 2021
@coloursofnoise coloursofnoise deleted the lib-stripped branch March 5, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants