feat(main): #82 edit and confirm with editor #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added config confirm_with_editor to open GIT_EDITOR / EDITOR. Default false. Closes: #82
Everduin94
commented
Feb 11, 2024
| if (config.confirm_with_editor) { | ||
| const options = config.overrides.shell ? { shell: config.overrides.shell, stdio: 'inherit' } : { stdio: 'inherit' } | ||
| const trailer = commit_state.trailer ? `--trailer="${commit_state.trailer}"` : ''; | ||
| execSync(`git commit -m "${build_commit_string(commit_state, config, false, true, false)}" ${trailer} --edit`, options); |
There was a problem hiding this comment.
There doesn't seem to be a type for {shell, stdio} (but there are types for each individually). Not sure if they're incompatible together, or I'm just missing a type casting?
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config confirm_with_editor to open GIT_EDITOR / EDITOR. Default false.
Closes: #82