-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename table
to recordbatch
#3771
refactor: rename table
to recordbatch
#3771
Conversation
CodSpeed Performance ReportMerging #3771 will degrade performances by 39.99%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3771 +/- ##
==========================================
- Coverage 75.59% 75.01% -0.59%
==========================================
Files 739 739
Lines 97206 96075 -1131
==========================================
- Hits 73484 72066 -1418
- Misses 23722 24009 +287
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
renames 'table' to 'recordbatch' to free up 'table' for upcoming catalog & table functionality.
note for reviewers:
a lot of files changed, but this was mostly a find and replace, so there shouldn't be much "logic" to actually review, just more of a sanity check to make sure I didn't terribly mess something up.