Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename table to recordbatch #3771

Merged

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Feb 5, 2025

renames 'table' to 'recordbatch' to free up 'table' for upcoming catalog & table functionality.

note for reviewers:
a lot of files changed, but this was mostly a find and replace, so there shouldn't be much "logic" to actually review, just more of a sanity check to make sure I didn't terribly mess something up.

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #3771 will degrade performances by 39.99%

Comparing universalmind303:daft-table-refactor (0500c6d) with main (8759b62)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_count[1 Small File] 3.3 ms 3.9 ms -13.71%
test_iter_rows_first_row[100 Small Files] 178.9 ms 298.2 ms -39.99%
test_show[100 Small Files] 23.8 ms 16 ms +48.98%

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 76.02592% with 111 lines in your changes missing coverage. Please review.

Project coverage is 75.01%. Comparing base (8759b62) to head (0500c6d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
daft/recordbatch/recordbatch.py 50.68% 36 Missing ⚠️
src/daft-micropartition/src/python.rs 37.50% 15 Missing ⚠️
daft/io/writer.py 0.00% 13 Missing ⚠️
src/daft-recordbatch/src/python.rs 60.00% 4 Missing ⚠️
daft/io/_deltalake.py 0.00% 3 Missing ⚠️
daft/io/_range.py 25.00% 3 Missing ⚠️
daft/sql/sql_scan.py 25.00% 3 Missing ⚠️
src/daft-micropartition/src/micropartition.rs 85.00% 3 Missing ⚠️
src/daft-parquet/src/python.rs 0.00% 3 Missing ⚠️
daft/recordbatch/micropartition.py 86.66% 2 Missing ⚠️
... and 23 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3771      +/-   ##
==========================================
- Coverage   75.59%   75.01%   -0.59%     
==========================================
  Files         739      739              
  Lines       97206    96075    -1131     
==========================================
- Hits        73484    72066    -1418     
- Misses      23722    24009     +287     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 85.51% <100.00%> (ø)
daft/delta_lake/delta_lake_scan.py 77.77% <100.00%> (ø)
daft/delta_lake/delta_lake_write.py 72.60% <100.00%> (ø)
daft/execution/execution_step.py 89.63% <100.00%> (ø)
daft/execution/native_executor.py 63.63% <100.00%> (ø)
daft/execution/physical_plan.py 94.35% <100.00%> (ø)
daft/filesystem.py 70.20% <100.00%> (ø)
daft/hudi/hudi_scan.py 87.95% <100.00%> (ø)
daft/iceberg/iceberg_scan.py 90.62% <100.00%> (ø)
daft/iceberg/iceberg_write.py 77.60% <100.00%> (ø)
... and 85 more

... and 69 files with indirect coverage changes

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@universalmind303 universalmind303 merged commit 7f2e9b5 into Eventual-Inc:main Feb 7, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants