Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): printSchema #3617

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

improve naming

f4a3051
Select commit
Loading
Failed to load commit list.
Open

feat(connect): printSchema #3617

improve naming
f4a3051
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 25, 2024 in 0s

77.65% (-0.34%) compared to e59581c

View this Pull Request on Codecov

77.65% (-0.34%) compared to e59581c

Details

Codecov Report

Attention: Patch coverage is 86.83386% with 42 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (e59581c) to head (f4a3051).

Files with missing lines Patch % Lines
src/daft-connect/src/display.rs 87.63% 35 Missing ⚠️
src/daft-connect/src/lib.rs 80.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3617      +/-   ##
==========================================
- Coverage   77.99%   77.65%   -0.34%     
==========================================
  Files         720      721       +1     
  Lines       88794    91520    +2726     
==========================================
+ Hits        69252    71070    +1818     
- Misses      19542    20450     +908     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/schema.rs 100.00% <100.00%> (ø)
src/daft-connect/src/lib.rs 65.01% <80.00%> (+2.13%) ⬆️
src/daft-connect/src/display.rs 87.63% <87.63%> (ø)

... and 14 files with indirect coverage changes