Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): Implement naive join ordering #3616

Merged
merged 11 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/common/scan-info/src/test/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@ use crate::{PartitionField, Pushdowns, ScanOperator, ScanTaskLike, ScanTaskLikeR
struct DummyScanTask {
pub schema: SchemaRef,
pub pushdowns: Pushdowns,
pub in_memory_size: Option<usize>,
}

#[derive(Debug)]
pub struct DummyScanOperator {
pub schema: SchemaRef,
pub num_scan_tasks: u32,
pub in_memory_size_per_task: Option<usize>,
}

#[typetag::serde]
Expand Down Expand Up @@ -67,7 +69,7 @@ impl ScanTaskLike for DummyScanTask {
}

fn estimate_in_memory_size_bytes(&self, _: Option<&DaftExecutionConfig>) -> Option<usize> {
None
self.in_memory_size
}

fn file_format_config(&self) -> Arc<FileFormatConfig> {
Expand Down Expand Up @@ -136,6 +138,7 @@ impl ScanOperator for DummyScanOperator {
let scan_task = Arc::new(DummyScanTask {
schema: self.schema.clone(),
pushdowns,
in_memory_size: self.in_memory_size_per_task,
});

Ok((0..self.num_scan_tasks)
Expand Down
1 change: 1 addition & 0 deletions src/daft-logical-plan/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ uuid = {version = "1", features = ["v4"]}
[dev-dependencies]
daft-dsl = {path = "../daft-dsl", features = ["test-utils"]}
pretty_assertions = {workspace = true}
rand = "0.8"
rstest = {workspace = true}
test-log = {workspace = true}

Expand Down
Loading
Loading