-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: OOM investigations of map-only pipelines #3558
Draft
jaychia
wants to merge
13
commits into
main
Choose a base branch
from
jay/big-materialization-ooms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3558 will degrade performances by 28.56%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
==========================================
- Coverage 77.81% 77.79% -0.02%
==========================================
Files 716 716
Lines 87987 88000 +13
==========================================
- Hits 68463 68461 -2
- Misses 19524 19539 +15
|
jaychia
force-pushed
the
jay/big-materialization-ooms
branch
from
December 13, 2024 02:32
7e46dac
to
2c4246f
Compare
jaychia
force-pushed
the
jay/big-materialization-ooms
branch
from
December 17, 2024 07:23
2b08029
to
60eed9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigations on OOM issues for map-only pipelines.
Tracking actual memory usage
Adds
memray
tracking to report the actual memory usage vs requested memory usage on our Ray tracing toolMock workload
Adds
benchmarking/ooms/big_task_heap_usage.py
which is a script that runs 2 UDFs with big heap memory usage (but small inputs/outputs)This can be run using:
Unit tests for memory usage
Unit tests to check our requested vs actual memory usage for selected plans