Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] add workflow to run tpch benchmarking #3328

Closed
wants to merge 14 commits into from

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Nov 18, 2024

Overview

Add a GitHub Actions workflow to only run tpch benchmarks given a commit-sha and a wheel name.

  • the logic will look at the appropriate AWS S3 bucket given those two inputs and find the correct wheel
  • then it will spawn a ray-cluster and run daft against the given tpch benchmarks

Note

I am merging this into feat/build-commit-workflow, and I will then merge that final branch into main. This is to help segment the purposes of each workflow, since they are highly reusable.

@github-actions github-actions bot added the enhancement New feature or request label Nov 18, 2024
@raunakab raunakab changed the base branch from main to feat/build-commit-workflow November 18, 2024 23:49
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #3328 will improve performances by 34.38%

Comparing feat/run-tpch (8a5b668) with feat/build-commit-workflow (ca82ffa)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark feat/build-commit-workflow feat/run-tpch Change
test_iter_rows_first_row[100 Small Files] 258.6 ms 195.1 ms +32.54%
test_show[100 Small Files] 29.8 ms 22.2 ms +34.38%

@jaychia jaychia removed the request for review from samster25 November 19, 2024 17:52
@jaychia
Copy link
Contributor

jaychia commented Nov 19, 2024

Is this ready for review? If it is, can we move it out of the draft state?

@raunakab raunakab removed the request for review from jaychia November 19, 2024 21:33
@raunakab
Copy link
Contributor Author

Closing in favour of #3184.

@raunakab raunakab closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants