[FEAT] Refactors and agg improvements for new local execution model #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samster25
approved these changes
Jul 10, 2024
| pub trait Source: Send + Sync { | ||
| async fn get_data( | ||
| &self, | ||
| ) -> Box<dyn Stream<Item = DaftResult<Arc<MicroPartition>>> + Send + Unpin>; |
There was a problem hiding this comment.
use boxstream as we talked about
| @@ -32,6 +35,6 @@ impl Source for ScanTaskSource { | |||
| // TODO: Implement dynamic splitting / merging of MicroPartition from scan task | |||
| Ok(Arc::new(out)) | |||
| })); | |||
| Box::pin(stream) | |||
| Box::new(stream) | |||
| Ok(Arc::new(out)) | ||
| } | ||
|
|
||
| fn name(&self) -> String { |
There was a problem hiding this comment.
no need to block here but this trait should return a &'static str so we don't need to perform a heap allocation each time we ask for the name
| } | ||
| } | ||
|
|
||
| impl IntermediateOperator for AggregateOperator { |
There was a problem hiding this comment.
future work: this should instead just be a blocking sink
| fn get_data(&self) -> Pin<Box<dyn Stream<Item = DaftResult<Arc<MicroPartition>>> + Send>> { | ||
| async fn get_data( | ||
| &self, | ||
| ) -> Box<dyn Stream<Item = DaftResult<Arc<MicroPartition>>> + Send + Unpin> { |
There was a problem hiding this comment.
favor typedef-ed BoxStream<DaftResult<Arc<MicroPartition>>>
|
|
||
| Box::pin(ReceiverStream::new(rx)) | ||
| Box::new(ReceiverStream::new(rx)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes source trait async
Connect to new local physical plan
Add incremental aggregations