Skip to content

Commit

Permalink
fix comment 2
Browse files Browse the repository at this point in the history
  • Loading branch information
frankliee committed Dec 29, 2024
1 parent fbe0a6f commit e72676f
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/daft-sql/src/modules/url.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ impl SQLFunction for UrlDownload {
args.max_connections,
args.raise_error_on_failure,
args.multi_thread,
Arc::try_unwrap(args.config).ok(), // upload requires Option<IOConfig>
Some(match Arc::try_unwrap(args.config) {
Ok(elem) => elem,
Err(elem) => (*elem).clone(),

Check warning on line 94 in src/daft-sql/src/modules/url.rs

View check run for this annotation

Codecov / codecov/patch

src/daft-sql/src/modules/url.rs#L88-L94

Added lines #L88 - L94 were not covered by tests
}), // download requires Option<IOConfig>
))
}
_ => unsupported_sql_err!("Invalid arguments for url_download: '{inputs:?}'"),

Check warning on line 98 in src/daft-sql/src/modules/url.rs

View check run for this annotation

Codecov / codecov/patch

src/daft-sql/src/modules/url.rs#L98

Added line #L98 was not covered by tests
Expand Down Expand Up @@ -182,7 +185,10 @@ impl SQLFunction for UrlUpload {
args.raise_error_on_failure,
args.multi_thread,
args.is_single_folder,
Arc::try_unwrap(args.config).ok(), // upload requires Option<IOConfig>
Some(match Arc::try_unwrap(args.config) {
Ok(elem) => elem,
Err(elem) => (*elem).clone(),

Check warning on line 190 in src/daft-sql/src/modules/url.rs

View check run for this annotation

Codecov / codecov/patch

src/daft-sql/src/modules/url.rs#L190

Added line #L190 was not covered by tests
}), // upload requires Option<IOConfig>
))
}
_ => unsupported_sql_err!("Invalid arguments for url_upload: '{inputs:?}'"),

Check warning on line 194 in src/daft-sql/src/modules/url.rs

View check run for this annotation

Codecov / codecov/patch

src/daft-sql/src/modules/url.rs#L194

Added line #L194 was not covered by tests
Expand Down

0 comments on commit e72676f

Please sign in to comment.