Run tests with Node LTS (#370)

EventStore · Apr 29, 2024 · aa6fd89 · aa6fd89
1 parent 03f3afa
commit aa6fd89
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 14 deletions.
diff --git a/.github/files/.nvmrc b/.github/files/.nvmrc
@@ -0,0 +1 @@
+18
diff --git a/.github/workflows/build_and_lint.yml b/.github/workflows/build_and_lint.yml
@@ -28,13 +28,18 @@ jobs:
   build:
     name: Build
     strategy:
+      fail-fast: true
       matrix:
-        os: [ubuntu-latest, windows-2019, macos-latest]
-
+        os: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: .github/files/.nvmrc
+      - name: NodeJS version
+        run: node -v
       - name: Install
         run: yarn
       - name: Build
@@ -45,11 +50,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out repository
-        uses: actions/checkout@v3
-      - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          node-version: "14.x"
+        uses: actions/checkout@v4
+      - name: NodeJS version
+        run: node -v
       - name: Install
         run: yarn
       - name: Build
@@ -79,4 +82,4 @@ jobs:
           --moduleResolution node
           --target es2018
           --lib es2020
-          --types node
+          --types node
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -43,7 +43,7 @@ jobs:
       SECRETS_AVAILABLE: ${{ secrets.eventstore_cloud_id != null }}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Connect to tailscale
         if: ${{ matrix.group.tailscale && env.SECRETS_AVAILABLE == 'true' }}
         run: |
@@ -52,10 +52,11 @@ jobs:
           sudo apt-get update
           sudo apt-get install tailscale
           sudo tailscale up --authkey ${{ secrets.tailscale_auth }} --hostname "node-client-ci-${{ inputs.version }}-$(date +'%Y-%m-%d-%H-%M-%S')" --advertise-tags=tag:ci --accept-routes
-      - name: Setup Node
-        uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: "14.x"
+          node-version-file: .github/files/.nvmrc
+      - name: NodeJS version
+        run: node -v
       - name: Install
         run: yarn
       - name: Run Tests
@@ -65,4 +66,4 @@ jobs:
           EVENTSTORE_CLOUD_ID: ${{ secrets.eventstore_cloud_id }}
       - name: Disconnect from tailscale
         if: ${{ always() && matrix.group.tailscale && env.SECRETS_AVAILABLE == 'true' }}
-        run: sudo tailscale down
+        run: sudo tailscale down