fix to solve issue with node v.0.12

[adrai]

solves: #41

[aslakhellesoy]

Can you add a test that proves this code is needed? -A test that would fail if the patch is not applied?

[adrai]

the problem is that the existing tests do not pass with 0.12...

[aslakhellesoy]

Oh I see. Maybe update the travis config would surface that?

[aslakhellesoy]

@adrai I've updated the travis config to use 0.12.0. Could you rebase your PR with master so we can see if all the tests will pass on 0.12.0?

Thanks

[adrai]

May you fix the existing tests?

[aslakhellesoy]

Yep I'll do that and let you know when it's done. Thanks!

[aslakhellesoy]

I've updated the tests so they run on Node.js 0.12.0 and Io.js 1.1.0.

Now you should be able to add a failing test demonstrating why your proposed patch is needed.

[adrai]

if a header value is undefined it would crash on 0.12

[aslakhellesoy]

I'm sure it does, but I still need a failing test to prove it. This will also prevent regressions in the future if someone refactors your code and breaks it.

The commits in this PR are a bit messy. It would be better if you could rebase instead of merging. Please fix that or send a new PR.

[adrai]

A new pull req is not a problem... but how should I do a failing test without mocking https://github.com/joyent/node/blob/master/lib/_http_outgoing.js#L333 ?
Isn't this enough https://github.com/adrai/eventsource-node/blob/patch-1/test/eventsource_test.js#L368 ?
Or do you want a dedicated test, that does exactly the same?

[aslakhellesoy]

I missed that you had added a X-something header. (the diff is hard to read now).

Yes, please ass that in a separate test, to make it explicit that we're testing this behaviour.

Thanks!