Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

feat(webpack): enable user to provide aliases though new config key #379

Closed
wants to merge 2 commits into from

Conversation

johangirod
Copy link
Contributor

@johangirod johangirod commented Jul 21, 2017

Add a new config key: webpack alias in .vitaminrc

Justification: sometimes, you want to be able to specify custome aliases, for instance for libraries
where entry point need some very specific webpack config to be built. In that case you may want to
use the compiled js instead (for instance, that the case of mapbox-gl
mapbox/mapbox-gl-js#1649)

❤️

Johan Girod added 2 commits July 21, 2017 14:20
…ey in .vitaminrc

Justification: sometimes, you want to be able to specify custome aliases, for instance for libraries
where entry point need some very specific webpack config to be built. In that case you may want to
use the compiled js instead (for instance, that the case of mapbox-gl
mapbox/mapbox-gl-js#1649
@LucasPerso
Copy link
Contributor

Hi @johangirod

Good to see your PR ! This is a very interesting feature !

We are currently working hard on rewriting the internal of vitaminjs and splitting the build logic from the runtime. There is a release candidate (1.3.0rc-2) on the way.
We will make sure to discuss your feature the next time the team meets and include it in the rewriting.

@johangirod
Copy link
Contributor Author

👌

@johangirod johangirod closed this Sep 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants