New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull() without a length does not pull until end of stream #10

Open

chad3814 opened this issue Mar 27, 2014 · 0 comments

chad3814 commented Mar 27, 2014

https://github.com/EvanOxfeld/node-pullstream/blob/master/pullstream.js#L46 calls self.read() if len is not set. Node docs http://nodejs.org/api/stream.html#stream_readable_stream says, "If you do not specify a size argument, then it will return all the data in the internal buffer."

I ran into this with a big stream, it just returned 16,384 bytes.

austinhallock pushed a commit to claydotio/node-pullstream that referenced this issue


          fix len=0 pull bug EvanOxfeld#10

363456f

austinhallock pushed a commit to claydotio/node-pullstream that referenced this issue


          fix len=0 pull bug EvanOxfeld#10

8cac4b9

austinhallock pushed a commit to claydotio/node-pullstream that referenced this issue


          fix len=0 pull bug EvanOxfeld#10

d6266b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment