Fix some test failures

European-XFEL · May 17, 2024 · 68d69a3 · 68d69a3
1 parent 9009878
commit 68d69a3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/extra_data/tests/test_validation.py b/extra_data/tests/test_validation.py
@@ -50,7 +50,7 @@ def test_zeros_in_train_ids(agipd_file):
 
     with raises(ValidationError) as excinfo:
         FileValidator(FileAccess(agipd_file)).validate()
-    problem = excinfo.value.problems.pop()
+    problem = excinfo.value.problems[0]
     assert problem['msg'] == 'Zeroes in trainId index before last train ID'
     assert problem['dataset'] == 'INDEX/trainId'
     assert 'RAW-R0239-AGIPD00-S00000.h5' in problem['file']

diff --git a/extra_data/validation.py b/extra_data/validation.py
@@ -373,7 +373,7 @@ def main(argv=None):
     args = ap.parse_args(argv)
 
     available_checks = {f.__name__ for f in FileValidator.check_funcs}
-    bad_skips = set(args.skip) - available_checks
+    bad_skips = set(args.skip or []) - available_checks
     if bad_skips:
         print("Unknown names passed to --skip:", ", ".join(sorted(bad_skips)))
         return 1