-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added two parameters: only-get-or-head and check-index #16
Conversation
Thank you for your contribution! 👍
Let me know if you intend to make the changes. 😃 |
Nice to see, that you reviewed my pull request! I committed "requested changes" and I can see it in this pull request - not sure, if you can see it, too. |
Okay, the requested modifications are working. Be aware, that I modified the README in "my" repo for copyright reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, for the work! 💪
I checked the code, just one tiny bug, a bit of cleaning up. Then I would love to merge 😃
I suggested all the changes so you just need to accept them 👍
as @Eun suggested Co-authored-by: Tobias Salzmann <796084+Eun@users.noreply.github.com>
as @Eun suggested Co-authored-by: Tobias Salzmann <796084+Eun@users.noreply.github.com>
as @Eun suggested Co-authored-by: Tobias Salzmann <796084+Eun@users.noreply.github.com>
as @Eun suggested Co-authored-by: Tobias Salzmann <796084+Eun@users.noreply.github.com>
as @Eun suggested Co-authored-by: Tobias Salzmann <796084+Eun@users.noreply.github.com>
as @Eun suggested Co-authored-by: Tobias Salzmann <796084+Eun@users.noreply.github.com>
I approved the changes and found an error in the README.md - Tabs instead of spaces. |
Yes you can delete your fork, thanks again 👍 |
It even says "If you wish, you can delete this fork of Eun/http-server-action in the settings." It was a pleasure to collaborate with you. |
Description
I am using your project to mock an API for testing purposes.
I needed two more functions to make it work.
Problem
I need to test API requests to something like /users/1 AND /users/1/profile .
So what I did was creating a folder structure and placed in the "/users/1"-folder an index.html
But it returns a directory listing even if a index.html is present.
And I need POST requests, but the original code blocks them.
Solution
Introduced parameter check-index for looking for index.html, before return directory listing.
Introduced parameter only-get-or-head to allow to set it to false, to ignore method check.
Notes
If you merge this, nothing significant will happen for existing users, because the default parameters say not to use the functions introduced in this request.