Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Electron to 32 as 29 is EOL #10118

Merged
merged 7 commits into from
Dec 31, 2024
Merged

Bump Electron to 32 as 29 is EOL #10118

merged 7 commits into from
Dec 31, 2024

Conversation

geodic
Copy link
Contributor

@geodic geodic commented Dec 26, 2024

The title says it...

@geodic
Copy link
Contributor Author

geodic commented Dec 26, 2024

It looks like the tests are failing as the image they are running on uses g++ 9 when the minimum required version is g++ 10. Updating the Ubuntu version should fix it...

@geodic
Copy link
Contributor Author

geodic commented Dec 31, 2024

@Eugeny, could you please take a look at this PR as soon as possible? Another PR is waiting on it. Thanks so much!

@geodic
Copy link
Contributor Author

geodic commented Dec 31, 2024

The build is successful! 🎊 🎊

@Eugeny
Copy link
Owner

Eugeny commented Dec 31, 2024

LGTM now, thanks!

@Eugeny Eugeny merged commit 1e44d8c into Eugeny:master Dec 31, 2024
10 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Dec 31, 2024

@all-contributors add @geodic for code

@geodic
Copy link
Contributor Author

geodic commented Dec 31, 2024

TSYM :)

@geodic
Copy link
Contributor Author

geodic commented Dec 31, 2024

@Eugeny, sorry for pinging you again, but I just wanted to ask if it's possible to release a new version so I can get the Nix PR merged. Thanks again!

@Eugeny
Copy link
Owner

Eugeny commented Jan 1, 2025

Currently not, v216 has introduced some major issues with SSH and I need to find a solution before pushing another update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants