Bump Electron to 32 as 29 is EOL #10118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the tests are failing as the image they are running on uses g++ 9 when the minimum required version is g++ 10. Updating the Ubuntu version should fix it... |
13 tasks
|
@Eugeny, could you please take a look at this PR as soon as possible? Another PR is waiting on it. Thanks so much! |
|
The build is successful! 🎊 🎊 |
|
LGTM now, thanks! |
|
@all-contributors add @geodic for code |
|
TSYM :) |
|
@Eugeny, sorry for pinging you again, but I just wanted to ask if it's possible to release a new version so I can get the Nix PR merged. Thanks again! |
|
Currently not, v216 has introduced some major issues with SSH and I need to find a solution before pushing another update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it...