Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with davvid/yaml-rust #2

Merged
merged 20 commits into from
Mar 19, 2024
Merged

Merge with davvid/yaml-rust #2

merged 20 commits into from
Mar 19, 2024

Conversation

davvid
Copy link
Collaborator

@davvid davvid commented Mar 17, 2024

Bring over all of the major updates from my fork at https://github.com/davvid/yaml-rust/
so that we can start recommending yaml-rust2 as the de-facto Rust YAML implementation.

@davvid
Copy link
Collaborator Author

davvid commented Mar 17, 2024

Related-to: rustsec/advisory-db#1921

Copy link
Owner

@Ethiraric Ethiraric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work! ❤️

I haven't reviewed anything CI-related as I haven't yet set it up for this repository, but I do assume it worked on your end and doesn't need tweaking?

justfile Outdated Show resolved Hide resolved
src/emitter.rs Outdated Show resolved Hide resolved
src/emitter.rs Show resolved Hide resolved
src/emitter.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/yaml.rs Show resolved Hide resolved
davvid and others added 20 commits March 18, 2024 20:30
Also helps in some cases with chyh1990#142, when the BOM is at the beginning of
the file (common), but not in corner case where the BOM is at the start
of a document which is not the first one.

Closes: chyh1990#155
Similarly to `or` for Rust's options, this patch provides a way to
'override' the value of a Yaml node if it's some form of error.
Allow the usage of `or` without consuming self. This can be useful
for pipelines that maintain some sort of owned state.
Garden is a simple command runner that uses YAML (via yaml-rust) as its
file format. Garden will be switching over to yaml-rust2 shortly.
Rename Scanner::next() to Scanner::next_token() to avoid
confusiong with the Iterator trait.
@davvid davvid requested a review from Ethiraric March 19, 2024 04:49
@Ethiraric Ethiraric merged commit 77e8fe7 into Ethiraric:master Mar 19, 2024
@Ethiraric
Copy link
Owner

Thanks a lot for your work on that merge!

@davvid davvid deleted the yaml-rust2/davvid branch March 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants