forked from chyh1990/yaml-rust
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with davvid/yaml-rust #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-to: rustsec/advisory-db#1921 |
Ethiraric
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your work! ❤️
I haven't reviewed anything CI-related as I haven't yet set it up for this repository, but I do assume it worked on your end and doesn't need tweaking?
Also helps in some cases with chyh1990#142, when the BOM is at the beginning of the file (common), but not in corner case where the BOM is at the start of a document which is not the first one. Closes: chyh1990#155
Similarly to `or` for Rust's options, this patch provides a way to 'override' the value of a Yaml node if it's some form of error.
Allow the usage of `or` without consuming self. This can be useful for pipelines that maintain some sort of owned state.
Garden is a simple command runner that uses YAML (via yaml-rust) as its file format. Garden will be switching over to yaml-rust2 shortly.
Rename Scanner::next() to Scanner::next_token() to avoid confusiong with the Iterator trait.
Ethiraric
approved these changes
Mar 19, 2024
Thanks a lot for your work on that merge! |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring over all of the major updates from my fork at https://github.com/davvid/yaml-rust/
so that we can start recommending yaml-rust2 as the de-facto Rust YAML implementation.