Merge pull request #9 from Etherna/improve/BEET-18-upload-chunks-with…

…-hash add hash check in chunk bulk upload
Etherna · Oct 16, 2024 · 4652cce · 4652cce
2 parents 39eb833 + 980298f
commit 4652cce
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/src/BeeTurbo/Handlers/ChunksBulkUploadHandler.cs b/src/BeeTurbo/Handlers/ChunksBulkUploadHandler.cs
@@ -65,6 +65,12 @@ public async Task HandleAsync(HttpContext httpContext)
                             chunkPayload[SwarmChunk.SpanSize..].ToArray(),
                             hasher);
                         var chunkRef = new UploadedChunkRef(hash, batchId);
+
+                        //read check hash
+                        var checkHash = ReadSwarmHash(payload.AsSpan()[i..(i + SwarmHash.HashSize)]);
+                        i += SwarmHash.HashSize;
+                        if (checkHash != hash)
+                            throw new InvalidDataException("Invalid hash with provided data");
 
                         await dbContext.ChunksBucket.UploadFromBytesAsync(hash.ToString(), chunkPayload);
                         await dbContext.ChunkPushQueue.CreateAsync(chunkRef);
@@ -78,13 +84,24 @@ public async Task HandleAsync(HttpContext httpContext)
         }
 
         // Helpers.
+        private static SwarmHash ReadSwarmHash(Span<byte> payload)
+        {
+            if (payload.Length != SwarmHash.HashSize)
+                throw new ArgumentOutOfRangeException(nameof(payload));
+
+            var valueByteArray = new byte[SwarmHash.HashSize];
+            for (int i = 0; i < valueByteArray.Length; i++)
+                valueByteArray[i] = payload[i];
+            return SwarmHash.FromByteArray(valueByteArray);
+        }
+
         private static ushort ReadUshort(Span<byte> payload)
         {
             if (payload.Length != sizeof(ushort))
                 throw new ArgumentOutOfRangeException(nameof(payload));
 
             var valueByteArray = new byte[sizeof(ushort)];
-            for (int i = 0; i < sizeof(ushort); i++)
+            for (int i = 0; i < valueByteArray.Length; i++)
                 valueByteArray[i] = payload[i];
             return BitConverter.ToUInt16(valueByteArray);
         }