Add full support for Diagnostic.code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,7 @@ import { MarkdownString } from './markdown-string'; | |||
| import { MarkdownString as MarkdownStringInterface } from '@theia/core/lib/common/markdown-rendering'; | |||
| import { TaskDto } from '../common/plugin-api-rpc'; | |||
| import { TaskGroup } from './types-impl'; | |||
| import { expect } from 'chai'; | |||
There was a problem hiding this comment.
I don't think this import is necessary, we can write our tests with assert instead like the rest of the file.
| @@ -332,12 +332,16 @@ export function convertDiagnosticToMarkerData(diagnostic: theia.Diagnostic): mod | |||
| }; | |||
| } | |||
|
|
|||
| function convertCode(code: string | number | undefined): string | undefined { | |||
| export function convertCode(code: string | number | { value: string | number; target: theia.Uri } | undefined): string | undefined { | |||
|
|
|||
EstFoisy
force-pushed
the
ef/11659
branch
4 times, most recently
from
c047833
to
3794302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add full support to Diagnostic.code according to the VS Code API.
closes eclipse-theia#11659
How to test
CI should pass
Review checklist
Reminder for reviewers