Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FillConstraint: Fix positioning not being accounted for #75

Closed
wants to merge 1 commit into from

Conversation

Sychic
Copy link
Member

@Sychic Sychic commented Jun 29, 2022

Previously did not account for the component's position within the parent, resulting in larger than expected sizing.

@Johni0702
Copy link
Contributor

This cannot be merged because:

  1. It changes existing behavior of FillConstraint (this is after all the point, but it will break code that has come to rely on the old behavior)
  2. It causes a cyclic constraints error if the component on which the FillConstraint is applied has a position constraint that directly or indirectly depends on its size
  3. It causes a cyclic constraints error if any sibling component has a position constraint that directly or indirectly depends on the size of the component
  4. It only accounts for padding on components on the left (those where that padding is being accounted for by the x position of the components) but not for any padding on components on the right. (granted, it didn't set out to do that, but it only working properly when left-aligned and breaking when right-aligned is certainly not great)

@Johni0702 Johni0702 closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants