ScrollComponent: Add a minimum scrollbar grip size #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that the vertical scroll bar grip is at least a minimum height, making it easier to grab when there is a lot of content within the ScrollComponent.
caoimhebyrne
force-pushed
the
feature/add-a-minimum-scroll-bar-height
branch
from
a913653 to
93a8aa9
Compare
Johni0702
requested changes
Jul 15, 2024
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
We can work directly with the values instead of creating a bunch of constraints which are only evaluated once before getting dropped.
We should also apply a minimum width to scrollbar grips.
caoimhebyrne
changed the title
limitScrollBarGripHeight option
caoimhebyrne
changed the title
Johni0702
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the vertical scroll bar grip is at least a minimum height, making it easier to grab when there is a lot of content within the ScrollComponent.