-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(inline-editable): add token theme tests #9648
Merged
eriklharper
merged 8 commits into
epic/7180-component-tokens
from
eriklharper/7180-inline-editable-theme-tests
Jun 21, 2024
Merged
test(inline-editable): add token theme tests #9648
eriklharper
merged 8 commits into
epic/7180-component-tokens
from
eriklharper/7180-inline-editable-theme-tests
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…design-system into eriklharper/7180-inline-editable-theme-tests
…design-system into eriklharper/7180-inline-editable-theme-tests
alisonailea
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks Erik!
Just a few things
packages/calcite-components/src/components/inline-editable/inline-editable.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/inline-editable/inline-editable.e2e.ts
Show resolved
Hide resolved
packages/calcite-components/src/components/inline-editable/inline-editable.scss
Show resolved
Hide resolved
alisonailea
approved these changes
Jun 21, 2024
benelan
added
autorelease: tagged
Pull requests created by release-please that were merged and deployed
and removed
autorelease: tagged
Pull requests created by release-please that were merged and deployed
labels
Jun 26, 2024
benelan
added a commit
that referenced
this pull request
Jul 9, 2024
… benelan/reset-chromatic-tokens-epic * origin/epic/7180-component-tokens: (222 commits) test(text-area): add component token E2E tests (#9729) test(themed): improve pseudoElement pattern test(rating): add theme token tests (#9700) test(block, block-section): add component token E2E tests (#9685) test(button, fab): add component token E2E tests (#9602) test(inline-editable): add token theme tests (#9648) fix(list, list-item, list-item-group): add e2e themed tests (#9616) test(shell-center-row): add token theming tests (#9462) test(shell): add token theming tests (#9458) fix build issues test(combobox, combobox-item-group, combobox-item): add component token E2E tests (#9599) test(radio-button): add component token E2E tests (#9591) test(card, card-group): add component token E2E tests (#9600) test(select): add component token E2E tests (#9593) test(icon): add component token E2E tests (#9595) test(label): add component token E2E tests (#9594) test(switch): add component token E2E tests (#9596) test(graph): add component token E2E tests (#9597) test(dropdown, dropdown-group): add component token E2E tests (#9598) test(tip, tip-group, tip-manager): add component token E2E tests (#9589) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds token theme tests for
calcite-inline-editable
.