Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump Stencil to v4.15.0 #9076

Closed
wants to merge 2 commits into from
Closed

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 6, 2024

Related Issue: N/A

Summary

🤜💥🤛

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Apr 6, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 6, 2024
@jcfranco jcfranco requested a review from a team as a code owner April 8, 2024 18:35
@jcfranco jcfranco changed the title chore(deps): bump Stencil to v4.14.1 chore(deps): bump Stencil to v4.15.0 Apr 8, 2024
@jcfranco
Copy link
Member Author

jcfranco commented Apr 8, 2024

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@jcfranco
Copy link
Member Author

Closing in favor of #9119.

@jcfranco jcfranco closed this Apr 13, 2024
@jcfranco jcfranco deleted the jcfranco/bump-stencil branch April 13, 2024 01:40
jcfranco added a commit that referenced this pull request May 10, 2024
**Related Issue:** #9087 

## Summary

Stencil [4.14.1 fixed the
issue](https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md#-4141-2024-04-04)
that prompted this custom rule.

Once we have [updated to the latest
version](#9076), we
should disable this rule and remove workarounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants