feat(tab): add component tokens #8852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
pr ready for visual snapshots
| @@ -3,7 +3,8 @@ | |||
| * | |||
| * These properties can be overridden using the component's tag as selector. | |||
| * | |||
| * @prop --calcite-tab-content-block-padding: Specifies the block padding of the component's content in the `default` slot. | |||
| * @prop --calcite-tab-content-block-padding: [Deprecated] Use `--calcite-tab-content-space` instead. Specifies the block padding of the component's content in the `default` slot. | |||
| * @prop --calcite-tab-content-space: Specifies the space of the component's content in the `default` slot. | |||
There was a problem hiding this comment.
Should this be “content block space”?
There was a problem hiding this comment.
Synced up w/ @alisonailea and landed on --calcite-tab-content-space-y. It's concise, readable and platform-agnostic.
There was a problem hiding this comment.
Do we need to update other space vars already merged?
There was a problem hiding this comment.
We should. I've got some block/block-section PRs to update. ✨💪✨
alisonailea
approved these changes
Feb 29, 2024
jcfranco
added
pr ready for visual snapshots
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following component tokens (CSS props):
--calcite-tab-content-space-yDeprecates the following:
--calcite-tab-content-block-padding