Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tip-manager): add component tokens #8782

Merged
merged 20 commits into from
Mar 14, 2024
Merged

feat(tip-manager): add component tokens #8782

merged 20 commits into from
Mar 14, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Feb 20, 2024 •
edited
Loading

Related Issue: #7180

Summary

Adds the following component tokens:

--calcite-tip-manager-content-height
--calcite-tip-manager-background-color
--calcite-tip-manager-text-color
--calcite-tip-manager-border-color

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Feb 20, 2024
@Elijbet Elijbet mentioned this pull request Feb 20, 2024
Open
@alisonailea alisonailea changed the base branch from main to epic/7180-component-tokens February 20, 2024 21:45
@Elijbet Elijbet marked this pull request as ready for review February 23, 2024 05:13
@Elijbet Elijbet requested a review from a team as a code owner February 23, 2024 05:13
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 23, 2024
jcfranco
jcfranco requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @Elijbet! 😎

packages/calcite-components/src/components/tip-manager/tip-manager.scss Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
alisonailea
alisonailea reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few things.

packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
alisonailea
alisonailea requested changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things.

packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/tip-manager.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/tip-manager.scss Show resolved Hide resolved
@Elijbet Elijbet merged commit 65d86b9 into epic/7180-component-tokens Mar 14, 2024
5 checks passed
@Elijbet Elijbet deleted the elijbet/7180-add-component-tokens-for-tip-manager branch March 14, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese left review comments

@jcfranco jcfranco jcfranco requested changes

@alisonailea alisonailea alisonailea approved these changes

@benelan benelan Awaiting requested review from benelan

@driskull driskull Awaiting requested review from driskull

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@Elijbet Elijbet

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Elijbet @jcfranco @alisonailea @macandcheese