Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): only focus on row when clicking a list item #11310

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(list): only focus on row when clicking a list item #11310

merged 2 commits into from
Jan 15, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Jan 15, 2025 •
edited
Loading

Related Issue: #11078

Summary

  • no longer focuses on cells when a cell is focused via click
  • only a row or cell can be focusable via tabindex at a time
  • update tests

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 15, 2025
@driskull driskull changed the title fix(list): only focus on row when clicking a list item. fix(list): only focus on row when clicking a list item Jan 15, 2025
@driskull driskull marked this pull request as ready for review January 15, 2025 21:14
eriklharper
eriklharper approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work pretty well, better than my stab at it. Thanks @driskull !

@eriklharper eriklharper mentioned this pull request Jan 15, 2025
Closed
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 15, 2025
@driskull driskull merged commit 8dcde2e into dev Jan 15, 2025
19 checks passed
@driskull driskull deleted the dris0000/list-focus-changes branch January 15, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @eriklharper