Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(combobox): fix initialization performance regression #11265

Merged
merged 1 commit into from
Jan 11, 2025
Merged

perf(combobox): fix initialization performance regression #11265

merged 1 commit into from
Jan 11, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 11, 2025 •
edited
Loading

Related Issue: #10731

Summary

#10952 increased the frequency of combobox's item-updating logic.

This improves performance by:

  • reducing the number of initial item update calls
  • debouncing the item update function to the next tick

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 11, 2025
@jcfranco jcfranco added the no changelog entry Use the commit override to avoid a changelog entry label Jan 11, 2025
@jcfranco jcfranco requested review from driskull and benelan January 11, 2025 01:24
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 11, 2025
driskull
driskull approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jcfranco jcfranco merged commit a255c5a into dev Jan 11, 2025
20 of 21 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-combobox-perf-regression branch January 11, 2025 07:53
@jcfranco jcfranco mentioned this pull request Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files. no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull