Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combobox-item): Add support for content-start slot #11250

Merged
merged 6 commits into from
Jan 10, 2025
Merged

feat(combobox-item): Add support for content-start slot #11250

merged 6 commits into from
Jan 10, 2025

Conversation

macandcheese
Copy link
Contributor

@macandcheese macandcheese commented Jan 10, 2025 •
edited
Loading

Related Issue: #9322

Summary

Adds support for content-start slot. @SkyeSeitz @ashetland can you confirm the "kitchen sink" case spacing with icon prop, slotted content, etc.

@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 10, 2025
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 10, 2025
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 10, 2025
@macandcheese macandcheese marked this pull request as ready for review January 10, 2025 02:25
@macandcheese macandcheese added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jan 10, 2025
@ashetland
Copy link
Contributor

CleanShot 2025-01-10 at 08 31 34@2x

driskull
driskull approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 10, 2025
@macandcheese
Copy link
Contributor Author

macandcheese commented Jan 10, 2025 •
edited
Loading

CleanShot 2025-01-10 at 08 31 34@2x

@ashetland I had the icon and content-start switched, the Chromatic should be up to date for review now, thanks.

ashetland
ashetland approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macandcheese macandcheese merged commit 233a7fd into dev Jan 10, 2025
15 checks passed
@macandcheese macandcheese deleted the macandcheese/9322-add-combobox-item-content-start-slot branch January 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland ashetland approved these changes

@driskull driskull driskull approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

@SkyeSeitz SkyeSeitz Awaiting requested review from SkyeSeitz

Assignees

@macandcheese macandcheese

Labels
enhancement Issues tied to a new feature or request. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
3 participants
@macandcheese @ashetland @driskull