Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): ignore disabled items when navigating via keyboard #11242

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix(autocomplete): ignore disabled items when navigating via keyboard #11242

merged 3 commits into from
Jan 9, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Jan 9, 2025 •
edited by github-actions bot
Loading

Related Issue: #11152

Summary

  • Only includes enabled items in keyboard navigation
  • disabled items are ignored

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE

@driskull driskull marked this pull request as ready for review January 9, 2025 19:18
@driskull driskull requested review from benelan and jcfranco January 9, 2025 19:18
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 9, 2025
@jcfranco jcfranco added the no changelog entry Use the commit override to avoid a changelog entry label Jan 9, 2025
jcfranco
jcfranco approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Before merging, can you add an E2E test for this?

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 9, 2025
@driskull driskull merged commit 2c55557 into dev Jan 9, 2025
10 checks passed
@driskull driskull deleted the dris0000/autocomplete-disabled-item-navigate-keyboard-fix branch January 9, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@benelan benelan Awaiting requested review from benelan

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco