Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): allow hiding icon #11239

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix(autocomplete): allow hiding icon #11239

merged 3 commits into from
Jan 9, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Jan 9, 2025 •
edited
Loading

Related Issue: #11224

Summary

  • allow icon to be set false
  • add tests

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 9, 2025
@driskull driskull changed the title fix(autocomplete, dom): fix default icon types fix(autocomplete): allow hiding icon Jan 9, 2025
@driskull driskull marked this pull request as ready for review January 9, 2025 06:22
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. no changelog entry Use the commit override to avoid a changelog entry labels Jan 9, 2025
eriklharper
eriklharper approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I assume that because of type="search" being set on calcite-input that a search icon will display when there's no icon prop passed to autocomplete, right?

@driskull
Copy link
Member Author

driskull commented Jan 9, 2025

LGTM! 👍 I assume that because of type="search" being set on calcite-input that a search icon will display when there's no icon prop passed to autocomplete, right?

Yep, thats right.

@driskull driskull merged commit 0cfd639 into dev Jan 9, 2025
25 checks passed
@driskull driskull deleted the dris0000/autocomplete-icon-fix-2 branch January 9, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper approved these changes

@benelan benelan Awaiting requested review from benelan

@jcfranco jcfranco Awaiting requested review from jcfranco

@anveshmekala anveshmekala Awaiting requested review from anveshmekala

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @eriklharper