Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(list)!: require label for context when dragging between lists #10702

Merged
merged 4 commits into from
Nov 15, 2024
Merged

feat(list)!: require label for context when dragging between lists #10702

merged 4 commits into from
Nov 15, 2024

Conversation

geospatialem
Copy link
Member

Related Issue: #7537

Summary

BREAKING CHANGE: The component's label property is required to provide context between lists when dragging.

@geospatialem geospatialem self-assigned this Nov 6, 2024
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 6, 2024
driskull
driskull approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geospatialem geospatialem added skip visual snapshots Pull requests that do not need visual regression testing. breaking change Issues and pull requests with code changes that are not backwards compatible. labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 14, 2024
@jcfranco jcfranco merged commit 5b84856 into dev Nov 15, 2024
9 of 10 checks passed
@jcfranco jcfranco deleted the geospatialem-list-label branch November 15, 2024 07:57
@geospatialem geospatialem mentioned this pull request Dec 4, 2024
Merged
geospatialem added a commit that referenced this pull request Dec 5, 2024
@geospatialem
docs(list): use lumina ref for required label property (#10989)
25a1732 
**Related PR:** #10702

## Summary

It looks like the new Lumina language wasn't included in the [original
PR](#10702). This PR
updates so the documentation picks up `list`'s required `label`
property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@geospatialem geospatialem

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

Successfully merging this pull request may close these issues.
3 participants
@geospatialem @driskull @jcfranco