Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(label): add component tokens #10688

Merged
merged 6 commits into from
Nov 15, 2024
Merged

feat(label): add component tokens #10688

merged 6 commits into from
Nov 15, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Nov 5, 2024

Related Issue: #7180

Summary

Add label component tokens.

--calcite-label-text-color: Specifies the component's text color.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 5, 2024
@driskull driskull marked this pull request as ready for review November 5, 2024 00:49
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 14, 2024
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor documentation change and we're good to go

@@ -4,6 +4,7 @@
* These properties can be overridden using the component's tag as selector.
*
* @prop --calcite-label-margin-bottom: The spacing below the component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to align with other token documentation can we rewrite this as --calcite-label-margin-bottom: Specifies the component's bottom spacing

# Conflicts:
#	packages/calcite-components/src/components.d.ts
#	packages/calcite-components/src/components/label/label.e2e.ts
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 15, 2024
@driskull driskull merged commit b2e694c into dev Nov 15, 2024
13 checks passed
@driskull driskull deleted the dris0000/label-tokens-7180 branch November 15, 2024 18:13
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:** #7180

## Summary

Add `label` component tokens.

`--calcite-label-text-color`: Specifies the component's text color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants