-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(progress)!: convert value range to 0-100 #10622
fix(progress)!: convert value range to 0-100 #10622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value being between 0 and 1 comes from the native progress:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#value
Plus this would be a breaking change in my opinion. If we want consistency, maybe we should change loader instead, which doesn't have a native equivalent.
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
7b111fb
to
b335773
Compare
We decided not to go with 0-1 because of this little study: #7207 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please roll back changes unrelated to the progress component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨🚀✨
packages/calcite-components/src/components/progress/progress.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related Issue: #7207
Summary
Fixes the discrepancy in value range used between Progress (0 -> 1.0) and Loader (0 -> 100), to have components use a similar expected value.
BREAKING CHANGE: Refactors
progress
to use the value range of 0-100. Developers will need to provide a function to map existing values or use the updated range.