Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panel, flow-item: add beforeClose property #9769

Closed
2 of 6 tasks
driskull opened this issue Jul 12, 2024 · 2 comments
Closed
2 of 6 tasks

panel, flow-item: add beforeClose property #9769

driskull opened this issue Jul 12, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-07-31 - Jul ...

Comments

@driskull
Copy link
Member

Check existing issues

Description

Add beforeClose property to both panel and flow-item in order to support stopping a panel from being closed.

Acceptance Criteria

panel, flow-item: add beforeClose property

Relevant Info

Required for dialog component

Which Component

panel, flow-item

Example Use Case

panel.beforeClose = () => Promise.reject();

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 12, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 12, 2024
@jcfranco jcfranco added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jul 12, 2024
@jcfranco jcfranco added this to the 2024-07-30 - Jul Release milestone Jul 12, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jul 12, 2024
driskull added a commit that referenced this issue Jul 12, 2024
@driskull
feat(panel, flow-item): add beforeClose property. #9769
e33413f
@driskull driskull mentioned this issue Jul 12, 2024
Merged
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 15, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

driskull added a commit that referenced this issue Jul 15, 2024
@driskull
feat(panel, flow-item): add beforeClose property (#9770)
fe32441 
**Related Issue:** #9769

## Summary

- adds `beforeClose` property to `panel` and `flow-item`
- allows close to be prevented via a function returning a promise that
could be rejected
- adds tests
@DitwanP
Copy link
Contributor

DitwanP commented Jul 15, 2024

🍡 Verified on 2.11.0-next.9

@DitwanP DitwanP closed this as completed Jul 15, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 15, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@driskull @github-actions
feat(panel, flow-item): add beforeClose property (#9770)
aefd3cb 
**Related Issue:** #9769

## Summary

- adds `beforeClose` property to `panel` and `flow-item`
- allows close to be prevented via a function returning a promise that
could be rejected
- adds tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @DitwanP