Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all components inherit font-family #9205

Closed
3 of 6 tasks
alisonailea opened this issue Apr 26, 2024 · 2 comments
Closed
3 of 6 tasks

Ensure all components inherit font-family #9205

alisonailea opened this issue Apr 26, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2024-04-30 - Apr ...

Comments

@alisonailea
Copy link
Contributor

alisonailea commented Apr 26, 2024 •
edited
Loading

Check existing issues

Description

Relates to #7175
Ensure all components inherit font-family and reference the variables from Calcite Design Tokens

Acceptance Criteria

  • calcite-presets should reference --calcite-font-family for sans fonts and --calcite-font-family-code for mono fonts.
  • there should not be any references to --calcite-sans-family in calcite-components
  • there should be no changes to the applied font faces in the UI

Relevant Info

No response

Which Component

all

Example Use Case

No response

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-design-tokens

Esri team

Calcite (design)
@alisonailea alisonailea added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 26, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Apr 26, 2024
@alisonailea alisonailea removed needs triage Planning workflow - pending design/dev review. Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. labels Apr 26, 2024
@alisonailea alisonailea added this to the 2024-04-30 - Apr Release milestone Apr 26, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. labels Apr 26, 2024
@alisonailea alisonailea mentioned this issue Apr 26, 2024
Merged
alisonailea added a commit that referenced this issue Apr 26, 2024
@alisonailea @jcfranco
feat: ensure all components inherit font-family (#8388)
90f8923 
**Related Issue:** #7175 #9205

## Summary

All components now inherit from the font-family set at root and that
font-family is inherited from tokens.
This also updates tailwind to use the font-family token

---------

Co-authored-by: JC Franco <jfranco@esri.com>
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Apr 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Apr 29, 2024

🍭 Verified

@DitwanP DitwanP closed this as completed Apr 29, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @DitwanP