Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative "REM" based tokens #8856

Open
7 of 14 tasks
alisonailea opened this issue Feb 29, 2024 · 1 comment
Open
7 of 14 tasks

Add relative "REM" based tokens #8856

alisonailea opened this issue Feb 29, 2024 · 1 comment
Assignees
Labels
2 - in development Issues that are actively being worked on. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone

Comments

@alisonailea
Copy link
Contributor

alisonailea commented Feb 29, 2024

Check existing issues

Description

Pre-November

November release

Calcite Design Tokens
Calcite Components

Acceptance Criteria

  • Semantic tier spacing, sizing, and font-size variables build to CSS with REM values with a 16px base
  • Calcite Components use Calcite Design Tokens for all spacing, sizing, and font-size references.
  • values for height, width, inline-size, block-size, and scale should use "sizing" tokens
  • values for padding, margin, gap, etc should use "spacing" tokens
  • line-height and font-size should use "font-size" tokens

Relevant Info

Tailwind has previously covered this with a selection of "applied" tailwind classes. In many components these have been replaces with direct "space" or "line-height" properties. So both will need to be searched for.

Which Component

All.

Example Use Case

.scale-m {
  @apply text-n1h;
  padding: var(--calcite-space-sm);
  max-width: var(--calcite-size-xxl);
}

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-design-tokens

Esri team

Calcite (dev)

@alisonailea alisonailea added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 29, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. p3 - want for upcoming milestone Calcite (dev) Issues logged by Calcite developers. labels Feb 29, 2024
@alisonailea alisonailea added the design-tokens Issues requiring design tokens. label Feb 29, 2024
@alisonailea alisonailea added the estimate - 2 Small fix or update, may require updates to tests. label Mar 18, 2024
@alisonailea
Copy link
Contributor Author

alisonailea commented Mar 18, 2024

This should be as easy as adding https://amzn.github.io/style-dictionary/#/transforms?id=sizepxtorem to the Design Token's build with a filter for specific token types. This requires some input from Design on naming.

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@github-actions github-actions bot added the p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone label Aug 13, 2024
@alisonailea alisonailea changed the title Add relative "REM" based line-height and spacing tokens Add relative "REM" based tokens Aug 13, 2024
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Aug 13, 2024
@alisonailea alisonailea self-assigned this Aug 15, 2024
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. 0 - new New issues that need assignment. and removed 0 - new New issues that need assignment. 2 - in development Issues that are actively being worked on. labels Aug 15, 2024
@alisonailea alisonailea removed their assignment Aug 15, 2024
@alisonailea alisonailea added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 2, 2024
@alisonailea alisonailea self-assigned this Dec 2, 2024
@alisonailea alisonailea removed the 1 - assigned Issues that are assigned to a sprint and a team member. label Jan 15, 2025
@alisonailea alisonailea added the 2 - in development Issues that are actively being worked on. label Jan 15, 2025
@DitwanP DitwanP added this to the 2025-02-25 - Feb Milestone milestone Jan 15, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - in development Issues that are actively being worked on. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone
Projects
None yet
Development

No branches or pull requests

3 participants