Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation Logo] Add heading-level Property #7075

Closed
macandcheese opened this issue May 31, 2023 · 2 comments
Closed

[Navigation Logo] Add heading-level Property #7075

macandcheese opened this issue May 31, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-04-30 - Apr ...

Comments

@macandcheese
Copy link
Contributor

Description

The heading text in Navigation Logo should be able to optionally render as a heading level, via a headingLevel property. This should not affect the visual display of the component, only the internally rendered component.

Acceptance Criteria

This should match other instances of this headingLevel property, such as in Panel: https://developers.arcgis.com/calcite-design-system/components/panel/#api-reference-properties-headingLevel

Relevant Info

No response

Which Component

Navigation Logo

Example Use Case

A user may want the rendered heading to render as a semantic heading level.

Priority impact

p4 - not time sensitive

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 31, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels May 31, 2023
@macandcheese macandcheese added the estimate - 2 Small fix or update, may require updates to tests. label Oct 25, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 26, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@josercarcamo josercarcamo self-assigned this Apr 3, 2024
@josercarcamo josercarcamo mentioned this issue Apr 3, 2024
Merged
@josercarcamo josercarcamo added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 3, 2024
josercarcamo added a commit that referenced this issue Apr 11, 2024
@josercarcamo
feat(navigation-logo): add heading level (#9054)
c2beba8 
**Related Issue:** #7075 

## Summary
Added the "headingLevel" property to navigation-logo, similar to Panel.
@josercarcamo josercarcamo added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned josercarcamo Apr 11, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Apr 12, 2024

🍡 Verified on main

@DitwanP DitwanP closed this as completed Apr 12, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

No branches or pull requests
4 participants
@macandcheese @geospatialem @DitwanP @josercarcamo