Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action-menu: using the keyboard to trigger the action isnt working #5559

Closed
kevindoshier opened this issue Oct 25, 2022 · 3 comments
Closed

action-menu: using the keyboard to trigger the action isnt working #5559

kevindoshier opened this issue Oct 25, 2022 · 3 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Milestone
Sprint 2022/10/24...

Comments

@kevindoshier
Copy link
Contributor

Actual Behavior

Tabbing into the action-menu, and then using the Enter key to trigger the action is not working

Expected Behavior

Tabbing into the action-menu, and then using the Enter key to trigger the action should trigger the action

Reproduction Sample

https://codepen.io/kevindoshier/pen/YzvzOZK

Reproduction Steps

  1. Open the sample above
  2. Tab to the "..."
  3. Tab to one of the action
  4. Press enter, observe in the console "Click!" is not output, however using the mouse click will trigger the action

Reproduction Version

beta.95

Relevant Info

No response

Regression?

No response

Esri team

ArcGIS Map Viewer
@kevindoshier kevindoshier added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 25, 2022
@github-actions github-actions bot added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Oct 25, 2022
@driskull driskull self-assigned this Oct 25, 2022
@driskull
Copy link
Member

I can take this one.

driskull added a commit that referenced this issue Oct 25, 2022
@driskull
fix(action-menu): fix keydown support. (#5559)
3a9298d 
Keyboard events should occur only on the menu button.
@driskull driskull mentioned this issue Oct 25, 2022
Merged
driskull added a commit that referenced this issue Oct 26, 2022
@driskull
fix(action-menu): fix keydown support (#5642)
8297482 
* fix(action-menu): fix keydown support. (#5559)

Keyboard events should occur only on the menu button.

* Add test

* review fixes
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Oct 26, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned driskull Oct 26, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 27, 2022
@geospatialem
Copy link
Member

Verified in beta.96 with both the space and Enter keys.

verify-action-keyboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
Sprint 2022/10/24 - 2022/11/04
Development

No branches or pull requests
4 participants
@driskull @geospatialem @benelan @kevindoshier