Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awkward space to the left and right of the sort handle in List #11125

Closed
2 of 6 tasks
ashetland opened this issue Dec 20, 2024 · 2 comments
Closed
2 of 6 tasks

Awkward space to the left and right of the sort handle in List #11125

ashetland opened this issue Dec 20, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2025-01-30 - 3.0....

Comments

@ashetland
Copy link
Contributor

ashetland commented Dec 20, 2024 •
edited
Loading

Check existing issues

Actual Behavior

There is space to the left of the sort handle in the v3 List that creates an awkward 4px where the handle cannot be grabbed. Also, without space to the right of the handle, the hover and focus states butt against the item content.
CleanShot 2024-12-20 at 10 53 11@2x

Expected Behavior

The space to the left is removed and space to the right is added.

Reproduction Sample

https://esri.github.io/calcite-design-system/?path=/story/components-list--scales

Reproduction Steps

Scroll to view the drag-enabled stories.

Reproduction Version

v3.0.0-next.80

Relevant Info

See this Figma file for spec changes to each scale.

cc @eriklharper

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 20, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Dec 20, 2024
@ashetland ashetland changed the title Space to the left and right of the sort handle in List Awkward space to the left and right of the sort handle in List Dec 20, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 20, 2024
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 26, 2024
@eriklharper eriklharper mentioned this issue Dec 27, 2024
Merged
eriklharper added a commit that referenced this issue Dec 30, 2024
@eriklharper
fix(list-item): improve drag handle spacing (#11156)
7b8b7d8 
**Related Issue:** #11125 

## Summary

This removes extra `inline-start` padding on the list-item's drag handle
for all scales and adds an appropriate amount of `inline-end` padding to
the handle in `selection-mode="none"` and
`selection-appearance="border"` variants.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 30, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Dec 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 3, 2025
@geospatialem
Copy link
Member

Verified in Storybook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
4 participants
@eriklharper @geospatialem @DitwanP @ashetland